-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update integrator_interface.jl with new interface information #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+334
to
+339
- `continuous_modification`: determines whether the modification is due to a continuous change (continuous callback) | ||
or a discrete callback. For a continuous change, this can include a change to time which requires a re-evaluation | ||
of the interpolations. | ||
- `callback_initializealg`: the initialization algorithm provided by the callback. For DAEs, this is the choice for the | ||
initialization that is done post callback. The default value of `nothing` means that the initialization choice | ||
used for the DAE should be performed post-callback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
- `continuous_modification`: determines whether the modification is due to a continuous change (continuous callback) | |
or a discrete callback. For a continuous change, this can include a change to time which requires a re-evaluation | |
of the interpolations. | |
- `callback_initializealg`: the initialization algorithm provided by the callback. For DAEs, this is the choice for the | |
initialization that is done post callback. The default value of `nothing` means that the initialization choice | |
used for the DAE should be performed post-callback. | |
- `continuous_modification`: determines whether the modification is due to a continuous change (continuous callback) | |
or a discrete callback. For a continuous change, this can include a change to time which requires a re-evaluation | |
of the interpolations. | |
- `callback_initializealg`: the initialization algorithm provided by the callback. For DAEs, this is the choice for the | |
initialization that is done post callback. The default value of `nothing` means that the initialization choice | |
used for the DAE should be performed post-callback. |
reeval_internals_due_to_modification!(integrator::DEIntegrator) | ||
end | ||
reeval_internals_due_to_modification!(integrator::DEIntegrator) = nothing | ||
reeval_internals_due_to_modification!(integrator::DEIntegrator; callback_initializealg = nothing) = nothing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
reeval_internals_due_to_modification!(integrator::DEIntegrator; callback_initializealg = nothing) = nothing | |
function reeval_internals_due_to_modification!( | |
integrator::DEIntegrator; callback_initializealg = nothing) | |
nothing | |
end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.