Remove dynamic dispatch from (General)LazyBufferCache #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sizemap::F | ||
| LazyBufferCache(f::F = identity) where {F <: Function} = new{F}(Dict(), f) # start with empty dict | ||
| end | ||
|
|
||
| # override the [] method | ||
| function Base.getindex(b::LazyBufferCache, u::T) where {T <: AbstractArray} | ||
| s = b.sizemap(size(u)) # required buffer size | ||
| buf = get!(b.bufs, (T, s)) do | ||
| get!(b.bufs, (T, s)) do |
There was a problem hiding this comment.
Does that change actually make a difference?
There was a problem hiding this comment.
Not at all. That is just for stylistic consistency with the rest of the file.
LilithHafner
changed the title
| may not be even measurable. The upside of `LazyBufferCache` is that the user does | ||
| not have to worry about potential issues with chunk sizes and such: `LazyBufferCache` | ||
| is much easier! | ||
| Note that `LazyBufferCache` is type-stable and contains no dynamic dispatch. This gives |
There was a problem hiding this comment.
doesn't it have an internal dynamic dispatch?
There was a problem hiding this comment.
No, it's just a lookup from a Dict{Any, Any}, which is not type stable, but doesn't have dynamic dispatch either.
Verified via @btime indicating no allocations and via @profview being a happy color (dynamic dispatch is supposed to show up in red)
(In theory the correct way to verify is JET)
There was a problem hiding this comment.
wow that's pretty incredible. Julia used to not be able to omit that.
This was referenced Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.