Improve IRC layout for SchildiChat: fix placement of capital letters inside read receipts #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inside read receipts This is a follow-up to 18578fe. Signed-off-by: Suguru Hirahara <[email protected]>
1 task
That's the correct thing to do, nothing else on your plate 👍 FYI I'll probably squash the commit with your existing patch for the next rebase (of course while maintaining authorship), to keep efforts at a minimum level. But that's something for us (the Schildi core team, who does upstream rebases) to do, so you don't need to worry about it. |
|
That's awesome! Thank you 😄 |
SpiritCroc
added a commit
to SchildiChat/schildichat-desktop
that referenced
this pull request
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to 18578fe (#4)
Since I'm not familiar with the workflow yet, I've created this PR against the branch for the latest release. Please let me know if there is anything I need to do.