-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to specify download-utility #16912
base: master
Are you sure you want to change the base?
Conversation
in host registration see also theforeman/foreman#9808
Can one of the admins verify this patch? |
if download_utility is not None: | ||
options['download-utility'] = download_utility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dosas Do you intent to add some test to cover this option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obviously I did not intent to ;) but if you point me in the right direction I can add a test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, this tests can be added to any of tests/foreman/{api,cli,ui}/test_registration.py
, and you can check of any e2e marked tests present in this modules for reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gauravtalreja1 I thought you were talking about a test in tests/robottelo
...
I doubt that we can add a meaningful e2e test for this on rhel operating systems because this option was specifically added for debian based operating systems where instead of curl wget is installed on default.
Or are you talking about a test where we just set the option explicitly to curl?
Problem Statement
newly added download utility option missing theforeman/foreman#9808
Solution
Add field
Related Issues
dependency SatelliteQE/nailgun#1257