Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI tests for Capsule Content Counts #13163

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Add CLI tests for Capsule Content Counts #13163

merged 2 commits into from
Jan 2, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Nov 22, 2023

Problem Statement

CLI coverage for Capsule Content Counts (new in 6.15) is missing.

Solution

This PR.

@vsedmik vsedmik added CLI Issues and PRs involving the CLI No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Nov 22, 2023
@vsedmik vsedmik self-assigned this Nov 22, 2023
@vsedmik vsedmik requested review from a team as code owners November 22, 2023 19:21
@vsedmik
Copy link
Contributor Author

vsedmik commented Nov 22, 2023

trigger: test-robottelo
pytest: tests/foreman/cli/test_capsulecontent.py

@vsedmik
Copy link
Contributor Author

vsedmik commented Nov 22, 2023 •
edited
Loading

PRT is failing because we are missing this PR in snap 38.
Fixed in snap 39 -> PRT passed.

lhellebr
lhellebr requested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@lhellebr lhellebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, a few questions

tests/foreman/cli/test_capsulecontent.py Show resolved Hide resolved
tests/foreman/cli/test_capsulecontent.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_capsulecontent.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_capsulecontent.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_capsulecontent.py Show resolved Hide resolved
@vsedmik vsedmik added the 6.15.z Introduced in or relating directly to Satellite 6.15 label Nov 29, 2023
@vsedmik
Copy link
Contributor Author

vsedmik commented Nov 29, 2023

trigger: test-robottelo
pytest: tests/foreman/cli/test_capsulecontent.py

@vsedmik vsedmik requested a review from lhellebr November 29, 2023 10:08
@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches and removed No-CherryPick PR doesnt need CherryPick to previous branches labels Nov 29, 2023
jyejare
jyejare approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK with curious question!

robottelo/cli/capsule.py Show resolved Hide resolved
tests/foreman/cli/test_capsulecontent.py Show resolved Hide resolved
@jyejare jyejare merged commit fab24d9 into SatelliteQE:master Jan 2, 2024
7 checks passed
@Satellite-QE Satellite-QE mentioned this pull request Jan 2, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Jan 2, 2024
@vsedmik @web-flow
Add CLI tests for Capsule Content Counts (#13163)
8062882 
* Add CLI tests for capsule content counts

* Address comments

(cherry picked from commit fab24d9)
vsedmik added a commit that referenced this pull request Jan 2, 2024
@Satellite-QE @vsedmik
[6.15.z] Add CLI tests for Capsule Content Counts (#13584)
4fa4e7b 
Add CLI tests for Capsule Content Counts (#13163)

* Add CLI tests for capsule content counts

* Address comments

(cherry picked from commit fab24d9)

Co-authored-by: vsedmik <[email protected]>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@vsedmik @shweta83
Add CLI tests for Capsule Content Counts (SatelliteQE#13163)
3fa8f25 
* Add CLI tests for capsule content counts

* Address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyejare jyejare jyejare approved these changes

@lhellebr lhellebr lhellebr approved these changes

Assignees

@vsedmik vsedmik

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches CLI Issues and PRs involving the CLI Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsedmik @lhellebr @jyejare