Add boolean field for content_default_http_proxy in HTTProxy entity #1254
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gauravtalreja1
added
the
No-CherryPick
LadislavVasina1
previously approved these changes
Nov 20, 2024
dosas
approved these changes
Nov 23, 2024
vsedmik
requested changes
Nov 25, 2024
nailgun/entities.py
Outdated
| @@ -5421,6 +5421,7 @@ def __init__(self, server_config=None, **kwargs): | |||
| 'organization': entity_fields.OneToManyField(Organization), | |||
| 'location': entity_fields.OneToManyField(Location), | |||
| 'cacert': entity_fields.StringField(), | |||
| 'default_content_http_proxy': entity_fields.BooleanField(), | |||
There was a problem hiding this comment.
Suggested change
| 'default_content_http_proxy': entity_fields.BooleanField(), | |
| 'default_content': entity_fields.BooleanField(), |
@Gauravtalreja1, could you provide some functional demonstration with ipython? I tried locally with packit VM for Katello/katello#11183 but I don't get the default_content_http_proxy on create nor on read back from API. We may need to add it to the ignore list if it's not returned.
Also, I didn't get the setting updated until I used default_content in the create call.
|
This pull request has not been updated in the past 45 days. |
|
@vsedmik How do we proceed here? |
Signed-off-by: Gaurav Talreja <[email protected]>
Gauravtalreja1
force-pushed
the
default-http-proxy-locator
branch
from
a837eca to
ae46f6b
Compare
Gauravtalreja1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Change introduced in Katello/katello#11183 and Katello/katello#11266