Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umekko #100

Closed
wants to merge 18 commits into from
Closed

Umekko #100

wants to merge 18 commits into from

Conversation

Umekko
Copy link

@Umekko Umekko commented Dec 22, 2024

Describe your change:

[TASK] - CPython

Closes https://github.com/SENATOROVAI/docs/issues/20

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Umekko and others added 18 commits December 1, 2024 21:10
Created new branch "Umekko", restored all files from local directory, installed linters and pre commit
Signed-off-by: Ruslan Senatorov <[email protected]>
Signed-off-by: Ruslan Senatorov <[email protected]>
Signed-off-by: Ruslan Senatorov <[email protected]>
Resolved an issue in round-function due an error in the rounding algorithm
Added new function "generateReport" to create reports about history of transactions
Updated code formatting and indentation without changing code logic
Added detailed description for function generateReport
Added tests for the "generateReport" function to make working flow more accurate
Signed-off-by: Ruslan Senatorov <[email protected]>
Signed-off-by: Ruslan Senatorov <[email protected]>
@Umekko Umekko requested a review from a team as a code owner December 22, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants