Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create inventory form #4918

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Create inventory form #4918

wants to merge 14 commits into from

Conversation

perryr16
Copy link
Contributor

@perryr16 perryr16 commented Dec 20, 2024

Any background context you want to provide?

Currently, the only way to introduce a new property or tax lot is through a data upload.

What's this PR do?

Introduces a new page available from the inventory nav to create a property or taxlot via a form. When the form is submitted, the backend creates a stub state, view, and property before using the existing "update" endpoint (inventory detail edit feature) to apply the configured state data passed from the frontend. By using the existing "update" endpoint, we can reuse the same matching/merging/linking functions.

notes:

  • If a new property includes a jurisdiction tax lot id, a taxlot with that id and any other taxlot fields will be created, then linked through a new TaxLotProperty.
  • Because a property create is treated as an "update" and not a data upload, the new property will not have a historical entry (building file) on the property detail.
  • If a property with a taxlot is created, there will be 2 backend requests, one for a property create and one for a taxlot create.
  • If a created property matches a property within the cycle, it is treated as an update and not a merge.

How should this be manually tested?

  • Test form functionality: add row, delete row, column list profile, reset...
  • Test validation: duplicate rows, missing matching criteria
  • Create a new property/taxlot with some canonical and extra data fields
  • Create a property/taxlot that matches an existing record in cycle
  • Create a property/taxlot that matches an existing record out of cycle
  • Create a property with an associated taxlot via jurisdiction tax lot id. The link should appear on the property detail under "Paired Tax Lots"

What are the relevant tickets?

#4846

Screenshots (if appropriate)

Screenshot 2025-01-08 at 10 58 46 AM

@perryr16 perryr16 added the Feature Add this label to new features. This will be reflected in the change log when generated. label Dec 20, 2024
@perryr16 perryr16 marked this pull request as ready for review January 9, 2025 15:55
@perryr16 perryr16 requested a review from kflemin January 9, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Add this label to new features. This will be reflected in the change log when generated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant