Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systems and services improvements #4879

Merged
merged 9 commits into from
Nov 27, 2024

Conversation

perryr16
Copy link
Contributor

@perryr16 perryr16 commented Nov 7, 2024

Any background context you want to provide?

What's this PR do?

Fixes 2, 3, 4, 5, 6, 7 from issue #4877

How should this be manually tested?

What are the relevant tickets?

Screenshots (if appropriate)

@perryr16 perryr16 added the Bug label Nov 7, 2024
@perryr16 perryr16 marked this pull request as ready for review November 22, 2024 21:50
@perryr16 perryr16 requested a review from haneslinger November 22, 2024 21:50
@haneslinger haneslinger merged commit 53bb3e9 into inventory-groups-develop Nov 27, 2024
9 checks passed
@haneslinger haneslinger deleted the 4877-system-improvements branch November 27, 2024 20:42
haneslinger pushed a commit that referenced this pull request Dec 11, 2024
* systen service modal mods

* update meter enums

* property display field

* alphabetical actions

* nav error and modal arrangement

* precommit

* unit refactors

* precommit

* fix tests

---------

Co-authored-by: Ross Perry <[email protected]>
kflemin added a commit that referenced this pull request Dec 13, 2024
* Inventory groups (#4726)

* Added inventory groups

* fixed formatting

* Add in AH

* Groups Details page

* Lint

* rp edits

* migration

* migration order

precommit

* lint

* fix tests

---------

Co-authored-by: Hannah Eslinger <[email protected]>
Co-authored-by: Ross Perry <[email protected]>
Co-authored-by: Ross Perry <[email protected]>

* Inventory groups frontend edits (#4820)

* Added inventory groups

* fixed formatting

* Add in AH

* Groups Details page

* Lint

* rp edits

* fix migrations

* add group buttons to inv detail

* groups to look like labels/dcs

* least common ancestor

* add all alis to group modal

* move lowest common to org view

* development

* migration

* member list default

* optimize lowest_common

* functional pre same node constraint

* validate inventorygroup for name and org

* fe error handling on group create

* mapping constraint, inventory and group must share ali

* precommit

* overhaul of the serializer and member list

* add and remove button bugs

* precommit

* merge conflicts

* merge conflicts

* Fix `hiredis` not found error (#4821)

Fix hiredis not found error

* navigation bugs

* navigation bugs

* troubleshooting

* id bug

* migration order

precommit

* lint

* fix tests

* integrate with develop

fix frontend tests

lint

* fix tests, simplify migration, formatting

precommit

* lint

* dry mapping presave

* group meters page

cleanup

cleanup

cleanup

broken

ali typo

meters page functional

* fix test

---------

Co-authored-by: Elizabeth <[email protected]>
Co-authored-by: Hannah Eslinger <[email protected]>
Co-authored-by: Ross Perry <[email protected]>
Co-authored-by: Ross Perry <[email protected]>
Co-authored-by: Ross Perry <[email protected]>
Co-authored-by: Alex Swindler <[email protected]>

* Add various inventory group features (#4837)

* descendant tree endpoint

* refactor group merges

---------

Co-authored-by: Ross Perry <[email protected]>

* Systems and services fe edits (#4860)

* Init systems and services

* Add Create Service UI and API

* create factories for groups and systems

* system test

* systems uigrids functional

documentation

* partial for system table

* Add connection type to meters

* refactor modal

* building update endpoint

* system endpoints

* service crud functional

precommit

* service sad path tests

error catching

service tests

* system sad path tests

* front end error handling

* Add meter import to sytems (#4857)

* Fix rollup table (#4835)

* default to float data type for axis data if data_type is not set on the selected column

---------

Co-authored-by: kflemin <[email protected]>

* More cts fixes (#4830)

Co-authored-by: Katherine Fleming <[email protected]>

* Init system meter upload

* Lock sass dependency and enforce Node v20 (#4855)

* use node version 20 for unittests

---------

Co-authored-by: Caleb Rutan <[email protected]>
Co-authored-by: kflemin <[email protected]>
Co-authored-by: Alex Swindler <[email protected]>
Co-authored-by: Ross Perry <[email protected]>
Co-authored-by: Ross Perry <[email protected]>

* fix test conflict

---------

Co-authored-by: Hannah Eslinger <[email protected]>
Co-authored-by: Ross Perry <[email protected]>
Co-authored-by: Caleb Rutan <[email protected]>
Co-authored-by: kflemin <[email protected]>
Co-authored-by: Alex Swindler <[email protected]>

* Updates to meter connection modal (#4868)

* Add modal to update meter connections

* Create update system meter connection endpoint

* modal development

* hookup group meter update

* Fix tests

* add config to serailized meter

* precommit

* comments

* fix test

* Add dashbard endpoint

* group header styling

* readable keys

* sort options

precommit

precommit

* migration

* precommit

* fix test

* hookup group meter delete

---------

Co-authored-by: Hannah Eslinger <[email protected]>
Co-authored-by: Ross Perry <[email protected]>

* Systems and services improvements (#4879)

* systen service modal mods

* update meter enums

* property display field

* alphabetical actions

* nav error and modal arrangement

* precommit

* unit refactors

* precommit

* fix tests

---------

Co-authored-by: Ross Perry <[email protected]>

* Redo group meter creation (#4889)

* Make create group meters modal

* Remove add meter button from systems and services page

* Init Group meter readings upload

* Fix dupe error

* Fix small things

* Make little UI fixes

* Add import/export to dashboard

* Remove meter attched to other services from groups meter/meterreading list

* Format

* Format

* Format

* linter

* translations and cleanup

* lint

* precommit

* dismiss action

* Fix meter usage

* Add message to mismatched meter readings

* Fix docker

* styles & linter

styles & linter

* fix group meter usage test

---------

Co-authored-by: Ross Perry <[email protected]>
Co-authored-by: kflemin <[email protected]>

* fix migration order

* Format

* precommit

* add service options to modal when meter already configured

* fix meter import tz issue

* lint

* add description text to group meters page

* make-aware for meter reading query

* precommit

* small bugs

lint

* adding missing migration

* precommit

---------

Co-authored-by: ebeers-png <[email protected]>
Co-authored-by: Ross Perry <[email protected]>
Co-authored-by: Ross Perry <[email protected]>
Co-authored-by: Ross Perry <[email protected]>
Co-authored-by: Elizabeth <[email protected]>
Co-authored-by: Ross Perry <[email protected]>
Co-authored-by: Alex Swindler <[email protected]>
Co-authored-by: Caleb Rutan <[email protected]>
Co-authored-by: kflemin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants