Added ability to invite users #171
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
Due to not finding any other solution I decided to write an action that automatically calculates the max height according to the screen height and the position of the text area. This is updated whenever the screen size changes.
Slartibartfass2
force-pushed
the
feat/16-use-case-invite-users
branch
from
fee36d2 to
51eef54
Compare
This is a component that displays information about a project member an offers actions to change their role or to remove them from the project
In version 2.46.1, which we previously used, eslint couldn't handle svelte each blocks without 'as'.
We use on of these blocks on the project members settings page (src/routes/project/[projectId]/settings/members/+page.svelte):
```svelte
{#each { length: numberOfSkeletons }, i}
<ProjectMemberListEntrySkeleton />
{#if i < numberOfSkeletons - 1}
<Separator />
{/if}
{/each}
```
This was reported in sveltejs/eslint-plugin-svelte#953 and fixed in version 3.0.0-next.5.
Now eslint works again with our codebase.
Slartibartfass2
force-pushed
the
feat/16-use-case-invite-users
branch
from
51eef54 to
94fb056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
C loses #19 (potentially)
C loses #24 (potentially)
What I have made
Checklist
Either tick or cross out the items that do not apply (using ~~example text~~) and give a reason why the item does not apply.