test framework: bulk reformat #4669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdbaddog
reviewed
Dec 21, 2024
| test = TestCmd.TestCmd(diff_stderr='diff_re') | ||
| print("diff_stderr:") | ||
| test.diff_stderr('a\nb.\nc\n', 'a\nbb\nc\n') | ||
| test.diff_stderr('a\\nb.\\nc\\n', 'a\\nbb\\nc\\n') |
There was a problem hiding this comment.
Is this right? it's escaping the newline so it'll show up as \n instead of being a newline?
There was a problem hiding this comment.
missed that one... I didn't think reformatting would change that. Will check into.
There was a problem hiding this comment.
Hmm, think the change is actually correct, as it's a string-in-a-string problem. Most of the other code snippets run via self.popen_python already did this escape-escaping.
There was a problem hiding this comment.
There's more than a handful of these changes in this file if I remember correctly. Were they broken before and just never tested?
bdbaddog
reviewed
Dec 21, 2024
| if (doCheckLog and | ||
| logfile.find( | ||
| "scons: warning: The stored build information has an unexpected class.") >= 0): | ||
| if ( |
bdbaddog
reviewed
Dec 21, 2024
Imcludes test snippets contained in docstrings, too. Signed-off-by: Mats Wichmann <[email protected]>
Insted of really long strings of repeated characters, use f-strings to compose the "expected" output for the banner function tests. This keeps the code formatter from breaking things an ugly way, and is really more "accurate" anyway. Signed-off-by: Mats Wichmann <[email protected]>
mwichmann
force-pushed
the
framework-black
branch
from
366b4c4 to
cf94507
Compare
bdbaddog
reviewed
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes test snippets contained in docstrings, too.
Note, once this is ready to merge, an additional commit should add the main commit hash to
.git-blame-ignore-revs(don't know which hash to add until we know this won't change anymore).CHANGES.txtandRELEASE.txt(and read theREADME.rst).