Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xSDK Changes #147

Merged
merged 7 commits into from
Dec 2, 2024
Merged

xSDK Changes #147

merged 7 commits into from
Dec 2, 2024

Conversation

Angelyr
Copy link
Contributor

@Angelyr Angelyr commented Nov 30, 2024

  • Doxygen page
  • Smoke test
  • optional print statement
  • print version

@Angelyr Angelyr requested review from cwsmith and jacobmerson and removed request for cwsmith November 30, 2024 21:36
cwsmith
cwsmith requested changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. A few comments are below.

Doxyfile Outdated Show resolved Hide resolved
src/pcms/print.cpp Outdated Show resolved Hide resolved
test/CMakeLists.txt Outdated Show resolved Hide resolved
@jacobmerson jacobmerson merged commit 72318ed into develop Dec 2, 2024
1 check passed
@jacobmerson
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobmerson jacobmerson jacobmerson approved these changes

@cwsmith cwsmith cwsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Angelyr @jacobmerson @cwsmith