Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue with ownerAddressUnstructured in BankAccountDetails model #15

Merged
merged 3 commits into from
May 4, 2024

Conversation

gritse
Copy link
Contributor

@gritse gritse commented May 3, 2024

I've received this for polish Pekao bank and got serialisation error:

/api/v2/accounts/{id}/details/

{
	"account": {
		"resourceId": "PL####################",
		"iban": "PL####################",
		"currency": "PLN",
		"ownerName": "#############",
		"product": "Rachunek oszczędnościowo – rozliczeniowy",
		"ownerAddressUnstructured": [
			"ZŁOTA 48-54 HOTEL MERCURE POKÓJ ###",
			"00-120 WARSZAWA",
			"POLSKA"
		]
	}
}

as we can see here, ownerAddressUnstructured is array of strings not just string. Official swagger for AccountDetailSchema also suggest that it's array: https://developer.gocardless.com/bank-account-data/endpoints

Copy link
Owner

@RobinTTY RobinTTY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting it and creating a PR. Since the library uses List for all enumerable types, please change the type, otherwise looks good :)

@gritse
Copy link
Contributor Author

gritse commented May 4, 2024

Thanks for reporting it and creating a PR. Since the library uses List for all enumerable types, please change the type, otherwise looks good :)

Thanks! I've changed to List<string>? as you suggested :)

@RobinTTY RobinTTY merged commit 24bac4c into RobinTTY:main May 4, 2024
3 checks passed
@RobinTTY
Copy link
Owner

RobinTTY commented May 4, 2024

@gritse Thanks, will create a new release shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants