-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library version v8.0.0 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… constructors by throwing exception when null is provided as argument
…startDate instead of executing request, update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
BasicError
type was removed since it has the same properties as theBasicResponse
type. This changes the signatures of the following methods:AccountsEndpoint.GetAccount()
now returnsTask<NordigenApiResponse<BankAccount, BasicResponse>>
instead ofTask<NordigenApiResponse<BankAccount, BasicError>>
AgreementsEndpoint.GetAgreements()
now returnsTask<NordigenApiResponse<ResponsePage<Agreement>, BasicResponse>>
instead ofTask<NordigenApiResponse<ResponsePage<Agreement>, BasicError>>
AgreementsEndpoint.GetAgreement()
now returnsTask<NordigenApiResponse<Agreement, BasicResponse>>
instead ofTask<NordigenApiResponse<Agreement, BasicError>>
AgreementsEndpoint.DeleteAgreement()
now returnsTask<NordigenApiResponse<BasicResponse, BasicResponse>>
instead ofTask<NordigenApiResponse<BasicResponse, BasicError>>
AgreementsEndpoint.AcceptAgreement()
now returnsTask<NordigenApiResponse<Agreement, BasicResponse>>
instead ofTask<NordigenApiResponse<Agreement, BasicError>>
InstitutionsEndpoint.GetInstitution()
now returnsTask<NordigenApiResponse<Institution, BasicResponse>>
instead ofTask<NordigenApiResponse<Institution, BasicError>>
RequisitionsEndpoint.GetRequisitions()
now returnsTask<NordigenApiResponse<ResponsePage<Requisition>, BasicResponse>>
instead ofTask<NordigenApiResponse<ResponsePage<Requisition>, BasicError>>
RequisitionsEndpoint.GetRequisition()
now returnsTask<NordigenApiResponse<Requisition, BasicResponse>>
instead ofTask<NordigenApiResponse<Requisition, BasicError>>
RequisitionsEndpoint.DeleteRequisition()
now returnsTask<NordigenApiResponse<BasicResponse, BasicResponse>>
instead ofTask<NordigenApiResponse<BasicResponse, BasicError>>
TokenEndpoint.GetTokenPair()
now returnsTask<NordigenApiResponse<JsonWebTokenPair, BasicResponse>>
instead ofTask<NordigenApiResponse<JsonWebTokenPair, BasicError>>
TokenEndpoint.RefreshAccessToken()
now returnsTask<NordigenApiResponse<JsonWebAccessToken, BasicResponse>>
instead ofTask<NordigenApiResponse<JsonWebAccessToken, BasicError>>
InstitutionsError
type has been removed and replaced byBasicResponse
since the error can in all cases be simplified to this type. This changes the signatures of the following method:InstitutionsEndpoint.GetInstitutions()
now returnsTask<NordigenApiResponse<List<Institution>, BasicResponse>>
instead ofTask<NordigenApiResponse<List<Institution>, InstitutionsError>>
AccountsEndpoint.GetTransactions()
now immediately throws anArgumentException
when theendDate
argument contains a date beforestartDate
instead of executing the response, since this will always result in an error being returned by the APIJsonWebTokenPair
andNordigenClientCredentials
now throw anArgumentNullException
when the suppliedstring
arguments arenull
Institution
type:TransactionTotalDays
property fromint
touint
since this value can't be negativeSupportedPayments
: The supported payment products for this institution (e.g.SepaCreditTransfers
,SwiftPaymentService
, etc.)SupportedFeatures
: The supported features for this institution (e.g.account_selection
,card_accounts
, etc.). This can inform you which features you can use when creating a requisition with an institution.IdentificationCodes
: Undocumented field in the response modelIEnumerable
toList
since most where already returningList
and to bring them in line. This affects the following properties:ResponsePage.Results
Tranasction.RemittanceInformationUnstructuredArray
Transaction.RemittanceInformationStructuredArray
Transaction.CurrencyExchange
Miscellaneous
TokenPairUpdated
event is now only raised when the token was successfully updated. In the past it was also raised for unsuccessful token refreshes. Therefore theTokenPairUpdatedEventArgs.JsonWebTokenPair
property is now no longer nullable.