update log and upgrade version library

RizkiMufrizal · Feb 28, 2024 · 4ce01e3 · 4ce01e3
1 parent 1a453ce
commit 4ce01e3
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 23 deletions.
diff --git a/pom.xml b/pom.xml
@@ -6,7 +6,7 @@
     <groupId>com.axway.maven.plugins</groupId>
     <artifactId>kps-maven-plugin</artifactId>
     <packaging>maven-plugin</packaging>
-    <version>1.1.0</version>
+    <version>1.1.1</version>
     <name>KPS Maven Plugin</name>
     <url>https://github.com/RizkiMufrizal/KPS-Maven-Plugin</url>
 
@@ -28,19 +28,19 @@
         <maven-plugin-plugin.version>3.8.1</maven-plugin-plugin.version>
         <maven-site-plugin.version>4.0.0-M6</maven-site-plugin.version>
         <maven-project-info-reports-plugin.version>3.4.2</maven-project-info-reports-plugin.version>
-        <spotbugs-maven-plugin.version>4.7.3.4</spotbugs-maven-plugin.version>
-        <spotbugs.version>4.7.3</spotbugs.version>
-        <findsecbugs-plugin.version>1.12.0</findsecbugs-plugin.version>
-        <maven-pmd-plugin.version>3.20.0</maven-pmd-plugin.version>
-        <jackson.version>2.14.2</jackson.version>
-        <jackson-dataformat-csv.version>2.14.2</jackson-dataformat-csv.version>
-        <lombok.version>1.18.26</lombok.version>
-        <httpclient5.version>5.2.1</httpclient5.version>
+        <spotbugs-maven-plugin.version>4.8.3.1</spotbugs-maven-plugin.version>
+        <spotbugs.version>4.8.3</spotbugs.version>
+        <findsecbugs-plugin.version>1.13.0</findsecbugs-plugin.version>
+        <maven-pmd-plugin.version>3.21.2</maven-pmd-plugin.version>
+        <jackson.version>2.16.1</jackson.version>
+        <jackson-dataformat-csv.version>2.16.1</jackson-dataformat-csv.version>
+        <lombok.version>1.18.30</lombok.version>
+        <httpclient5.version>5.3.1</httpclient5.version>
         <ascii-table.version>1.8.0</ascii-table.version>
-        <slf4j.version>2.0.7</slf4j.version>
-        <junit-jupiter-api.version>5.9.2</junit-jupiter-api.version>
-        <junit-jupiter-engine.version>5.9.2</junit-jupiter-engine.version>
-        <wiremock-jre8.version>2.35.0</wiremock-jre8.version>
+        <slf4j.version>2.0.12</slf4j.version>
+        <junit-jupiter-api.version>5.10.2</junit-jupiter-api.version>
+        <junit-jupiter-engine.version>5.10.2</junit-jupiter-engine.version>
+        <wiremock.version>3.4.2</wiremock.version>
         <maven-surefire-plugin.version>3.0.0</maven-surefire-plugin.version>
         <maven-failsafe-plugin.version>3.0.0</maven-failsafe-plugin.version>
     </properties>
@@ -115,9 +115,9 @@
             <scope>test</scope>
         </dependency>
         <dependency>
-            <groupId>com.github.tomakehurst</groupId>
-            <artifactId>wiremock-jre8</artifactId>
-            <version>${wiremock-jre8.version}</version>
+            <groupId>org.wiremock</groupId>
+            <artifactId>wiremock</artifactId>
+            <version>${wiremock.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

diff --git a/src/main/java/com/axway/maven/kps/common/Logger.java b/src/main/java/com/axway/maven/kps/common/Logger.java
@@ -12,10 +12,4 @@ public static void logError(Exception e, String message) {
         e.printStackTrace(new PrintWriter(stringWriter));
         log.error(message, stringWriter);
     }
-
-    public static void logError(Throwable e, String message) {
-        StringWriter stringWriter = new StringWriter();
-        e.printStackTrace(new PrintWriter(stringWriter));
-        log.error(message, stringWriter);
-    }
 }
diff --git a/src/test/java/com/axway/maven/kps/csv/impl/ConvertJsonImplTest.java b/src/test/java/com/axway/maven/kps/csv/impl/ConvertJsonImplTest.java
@@ -31,7 +31,7 @@ void testToString() throws JsonProcessingException {
         log.info("Convert Object Map {}", stringObjectMap);
         String mapToJsonString = this.convert.toString(stringObjectMap);
         assertNotNull(mapToJsonString);
-        assertTrue(mapToJsonString.length() > 0);
+        assertFalse(mapToJsonString.isEmpty());
         assertEquals(mapToJsonString, "{\"Message\":\"Success Message\",\"Sucess\":true}");
     }