Fixes #440 - Reduce chance of false positives for pdf.js #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generic pattern with the npm style co-ordinates seems unnecessary for detection as the test cases all pass without this pattern included. Signed-off-by: Chad Wilson <[email protected]>
eoftedal
approved these changes
Jul 10, 2024
|
Thank you, @chadlwilson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic pattern with the npm style co-ordinates seems unnecessary for detection as the test cases all pass without this pattern included.
Ran all the tests prior, and also experimented with some other versions just in case. Didn't add them to the test list, as all seems OK and similar to current structures.