Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8 add Ending Diameter activity explicitly from SBB function #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xphudin
Copy link

@xphudin xphudin commented Nov 8, 2016

hi @brainslog @deruelle
I have just finished the work discuss before on that issue.
Can you please review it?
Thanks

@deruelle
Copy link
Member

deruelle commented Nov 8, 2016

Thanks @xphudin ! @brainslog can you please review ?

@SergeyLee
Copy link
Contributor

Hi @xphudin @brainslog !
Can we realize this ending on Diameter protocol level?
What about expiration (and expiration time)?
As I read spec 8.4. Session Termination:

When a user session that required Diameter authorization terminates,
the access device that provided the service MUST issue a Session-
Termination-Request (STR) message to the Diameter server that
authorized the service, to notify it that the session is no longer
active. An STR MUST be issued when a user session terminates for any
reason, including user logoff, expiration of Session-Timeout,
administrative action, termination upon receipt of an Abort-Session-
Request (see below), orderly shutdown of the access device, etc.

@xphudin xphudin force-pushed the master branch 3 times, most recently from 035d23b to 6fc57d3 Compare January 9, 2017 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants