Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were several issues flagged by GCC when using LTO. The things I fixed are the following:
cblas_f77.h
header contained some wrong declarations, where complex arguments had types likefloat*
ordouble*
instead ofvoid*
LAPACK_lsame
declaration had 4 STRLEN arguments instead of the necessary 2I compiled with
-Werror=lto-type-mismatch
and it seems all issues are resolved.We could enable LTO in the CI pipelines (CMake:
-DCMAKE_INTERPROCEDURAL_OPTIMIZATION=ON
) and add the-Werror=lto-type-mismatch
flag as well now.Fixes #334
Fixes #990
Checklist