Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lto type mismatch #1027

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Conversation

ACSimon33
Copy link
Contributor

@ACSimon33 ACSimon33 commented Jun 19, 2024

Description

There were several issues flagged by GCC when using LTO. The things I fixed are the following:

  • The cblas_f77.h header contained some wrong declarations, where complex arguments had types like float* or double* instead of void*
  • The CBLAS examples showcasing the external 64bit interface actually used the normal interface instead. Some definitions and includes needed to be reordered
  • The CBLAS testing framework was missing the hidden FORTRAN_STRLEN arguments
  • The LAPACK_lsame declaration had 4 STRLEN arguments instead of the necessary 2

I compiled with -Werror=lto-type-mismatch and it seems all issues are resolved.

We could enable LTO in the CI pipelines (CMake: -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=ON) and add the -Werror=lto-type-mismatch flag as well now.

Fixes #334
Fixes #990

Checklist

  • If the PR solves a specific issue, it is set to be closed on merge.

@ACSimon33
Copy link
Contributor Author

@martin-frbg If this is accepted, we probably could take a look at OpenMathLib/OpenBLAS#4128 again

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (690067c) to head (4f504e0).
Report is 20 commits behind head on master.

Current head 4f504e0 differs from pull request most recent head 51219d2

Please upload reports for the commit 51219d2 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1027   +/-   ##
=======================================
  Coverage    0.00%    0.00%           
=======================================
  Files        1933     1933           
  Lines      190594   190594           
=======================================
  Misses     190594   190594           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@langou langou merged commit 564dae9 into Reference-LAPACK:master Jun 20, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure with -Werror=lto-type-mismatch Mismatch of subroutine declarations in Lapack 3.8.0 in testing
2 participants