Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oobtkube to test leaf keys in arrays #276

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Conversation

sfowl
Copy link
Collaborator

@sfowl sfowl commented Jan 7, 2025

Draft for now, creating PR to run e2e tests Ready for review

Update for oobtkube script to also test array elements, not just dictionary keys in k8s objects. This replaces the approach of using sed to modify yaml files, instead modifying the nested dict/list objects then writing them to temporary yaml files, later applied with kubectl. Minor related changes include:

  • Logfile message tweaks, full paths to leaf keys are now printed, not just the final leaf key
  • A small hardcoded delay (1sec) occurs after successful create/replace of k8s objects, to allow for more time for injected commands to run
  • k8s object fields beyond spec are now tested, the only top level keys which are skipped are: apiVersion, kind and metadata

@sfowl sfowl self-assigned this Jan 7, 2025
@sfowl sfowl marked this pull request as ready for review January 7, 2025 04:18
@sfowl sfowl requested a review from a team as a code owner January 7, 2025 04:18
Copy link
Collaborator

@jeremychoi jeremychoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfowl sfowl merged commit b7ec784 into development Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants