Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use application/json instead of multipart/form-data format #46

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Use application/json instead of multipart/form-data format #46

merged 2 commits into from
Jun 4, 2024

Conversation

JakubFrejlach
Copy link
Collaborator

@JakubFrejlach JakubFrejlach commented Jun 4, 2024 •
edited
Loading

This PR:

  • changes osidb-bindings requests data format to preferably use application/json as multipart/form-data is causing serialization issues on the OSIDB side (in the future OSIDB will restrict using the application/json exclusively to avoid discrepancies between different API users/OSIM/etc.)

Closes OSIDB-2844

@JakubFrejlach
Use json preferably instead of form-data
d337b1b 
OSIDB currently accepts multipart/form-data, application/x-www-form-urlencoded
and application/json requests format. osidb-bindings are currently
preferably using multipart/form-data however this requests causes
slightly different behavior for some of the OSIDB serializers and
results into serialization failures.
@JakubFrejlach
Update changelog
9cbd70f
@JakubFrejlach JakubFrejlach self-assigned this Jun 4, 2024
JimFuller-RedHat
JimFuller-RedHat approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@JimFuller-RedHat JimFuller-RedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JakubFrejlach JakubFrejlach merged commit f8459e0 into master Jun 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimFuller-RedHat JimFuller-RedHat JimFuller-RedHat approved these changes

Assignees

@JakubFrejlach JakubFrejlach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakubFrejlach @JimFuller-RedHat