RHCLOUD-37310 | fix: rename email subscription user IDs to lowercase #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a customer report where they complained that they were still receiving Errata notifications even after unsubscribing from them. After investigating, we found out that we had multiple and even overlapping email subscriptions for almost the same username. By "almost", I mean that the username was essentially the same, but with different case. For example: UserA and usera. Notifications takes all the email subscriptions' usernames and makes them lowercase to make a case insensitive comparison. Also, when user preferences are saved, the email subscriptions that are generated are generated with lowercase user IDs. When we migrated the Errata email subscriptions, some of them contained mixed case user IDs, and we did not realize about that. What ended up happening was: - A customer was initially subscribed to errata Notifications, and therefore we migrated their email subscription from Errata with a mixed case. - The customer unsubscribed, which generated a lowercase email unsubscription. - The recipients resolver took both subscriptions and since it still found the mixed case subscription, it was sending the email. RHCLOUD-37310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a customer report where they complained that they were still receiving Errata notifications even after unsubscribing from them.
After investigating, we found out that we had multiple and even overlapping email subscriptions for almost the same username. By "almost", I mean that the username was essentially the same, but with different case. For example: UserA and usera.
Notifications takes all the email subscriptions' usernames and makes them lowercase to make a case insensitive comparison. Also, when user preferences are saved, the email subscriptions that are generated are generated with lowercase user IDs.
When we migrated the Errata email subscriptions, some of them contained mixed case user IDs, and we did not realize about that.
What ended up happening was:
Jira ticket
[RHCLOUD-37310]