[RHCLOUD-37053] Simplify email connector internal logic #3227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-duval
force-pushed
the
RHCLOUD-37053_simplifyEmailConnectorInternalLogic
branch
2 times, most recently
from
05d1d03 to
2e432fc
Compare
g-duval
commented
Jan 6, 2025
| .choice() | ||
| .when(shouldUseSimplifiedEmailManagement()) | ||
| .process(emailManagementProcessor) | ||
| .endChoice() |
There was a problem hiding this comment.
Each when and otherwise cases have to be closed explicitly when a sub choice is involve.
g-duval
commented
Jan 6, 2025
| @@ -182,8 +183,12 @@ public Optional<String> getRecipientsResolverTrustStoreType() { | |||
| return recipientsResolverTrustStoreType; | |||
| } | |||
|
|
|||
| public boolean isEnableBopServiceWithSslChecks() { | |||
There was a problem hiding this comment.
Remove constant config
g-duval
commented
Jan 6, 2025
| @@ -105,16 +110,10 @@ public void configureRoutes() { | |||
| // Clear all the headers that may come from the previous route. | |||
| .removeHeaders("*") | |||
| .process(this.BOPRequestPreparer) | |||
| .choice().when(shouldUseBopEmailServiceWithSslChecks()) | |||
There was a problem hiding this comment.
The involved config flag was turned into a constant a while ago.
g-duval
force-pushed
the
RHCLOUD-37053_simplifyEmailConnectorInternalLogic
branch
from
2e432fc to
348210e
Compare
jessicarod7
reviewed
Jan 7, 2025
...l/src/main/java/com/redhat/cloud/notifications/connector/email/EmailManagementProcessor.java
Outdated
Show resolved
Hide resolved
…onnector/email/EmailManagementProcessor.java Co-authored-by: Jessica Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.