Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip users without email addresses from IT service #3143

Merged
merged 6 commits into from
Nov 29, 2024

Conversation

g-duval
Copy link
Contributor

@g-duval g-duval commented Nov 25, 2024

No description provided.

@g-duval g-duval changed the title Skip users without email addresses from id service Skip users without email addresses from IT service Nov 25, 2024
@g-duval
Copy link
Contributor Author

g-duval commented Nov 26, 2024

/retest

@g-duval g-duval requested a review from gwenneg November 28, 2024 09:47
Copy link
Member

@MikelAlejoBR MikelAlejoBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…ns/recipients/resolver/FetchUsersFromExternalServices.java

Co-authored-by: Mikel Alejo <[email protected]>
Copy link
Member

@gwenneg gwenneg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gwenneg gwenneg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing.

@g-duval
Copy link
Contributor Author

g-duval commented Nov 28, 2024

Tests are failing.

oups!

@g-duval g-duval requested a review from gwenneg November 28, 2024 14:52
@gwenneg gwenneg merged commit fee97da into RedHatInsights:master Nov 29, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants