Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCLOUD-34485 | feature: update API for Kessel Inventory's client #3124

Merged
merged 1 commit into from
Nov 14, 2024
Merged

RHCLOUD-34485 | feature: update API for Kessel Inventory's client #3124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/main/java/com/redhat/cloud/notifications/auth/kessel/KesselAssets.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ protected CreateNotificationsIntegrationRequest buildCreateIntegrationRequest(fi
NotificationsIntegration.newBuilder()
.setMetadata(Metadata.newBuilder()
.setResourceType(ResourceType.INTEGRATION.getKesselRepresentation())
.setWorkspace(workspaceId)
.setWorkspaceId(workspaceId)
.build()
).setReporterData(ReporterData.newBuilder()
.setLocalResourceId(integrationId)
Expand Down
2 changes: 1 addition & 1 deletion backend/src/test/java/com/redhat/cloud/notifications/auth/kessel/KesselAssetsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ void testBuildCreateIntegrationRequest() {
// Assert that the request was properly built.
final Metadata metadata = request.getIntegration().getMetadata();
Assertions.assertEquals(ResourceType.INTEGRATION.getKesselRepresentation(), metadata.getResourceType(), "the \"resource type\" should have been an integration");
Assertions.assertEquals(workspaceId, metadata.getWorkspace(), "the workspace ID was incorrectly set");
Assertions.assertEquals(workspaceId, metadata.getWorkspaceId(), "the workspace ID was incorrectly set");

final ReporterData reporterData = request.getIntegration().getReporterData();
Assertions.assertEquals(integrationId, reporterData.getLocalResourceId(), "the \"local resource id\" was incorrectly set");
Expand Down
2 changes: 1 addition & 1 deletion backend/src/test/java/com/redhat/cloud/notifications/routers/EndpointResourceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4227,7 +4227,7 @@ void testIntegrationCreationRemovalKesselInventory(final boolean isKesselRelatio
NotificationsIntegration.newBuilder()
.setMetadata(Metadata.newBuilder()
.setResourceType(ResourceType.INTEGRATION.getKesselRepresentation())
.setWorkspace(KesselTestHelper.RBAC_DEFAULT_WORKSPACE_ID.toString())
.setWorkspaceId(KesselTestHelper.RBAC_DEFAULT_WORKSPACE_ID.toString())
.build()
).setReporterData(ReporterData.newBuilder()
.setLocalResourceId(integrationId.toString())
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@

<properties>
<mapstruct.version>1.6.2</mapstruct.version>
<kessel.inventory-client.version>0.5</kessel.inventory-client.version>
<kessel.inventory-client.version>0.7</kessel.inventory-client.version>
<kessel.oauth-client.version>11.20.1</kessel.oauth-client.version>
<kessel.relationships-client.version>0.10</kessel.relationships-client.version>

Expand Down
Loading