Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHCLOUD-35969] drop orphans system endpoints #3075

Merged
merged 3 commits into from
Nov 27, 2024
Merged

[RHCLOUD-35969] drop orphans system endpoints #3075

merged 3 commits into from
Nov 27, 2024

Conversation

g-duval
Copy link
Contributor

@g-duval g-duval commented Oct 29, 2024

No description provided.

@g-duval g-duval marked this pull request as ready for review October 29, 2024 13:59
MikelAlejoBR
MikelAlejoBR approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@MikelAlejoBR MikelAlejoBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One question: we don't need to check the endpoint_event_type table, right?

gwenneg
gwenneg approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@gwenneg gwenneg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gwenneg
gwenneg requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@gwenneg gwenneg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SQL file needs to be renamed to V1.106.

@g-duval
Copy link
Contributor Author

g-duval commented Nov 27, 2024

LGTM! One question: we don't need to check the endpoint_event_type table, right?

No we don't have to @MikelAlejoBR, because those endpoints were generated automatically by aggregation process which skips event_type associations.

@MikelAlejoBR
Copy link
Member

Sounds good, thanks!

@g-duval g-duval force-pushed the RHCLOUD-35969_dropOrphansSystemEndpoints branch from 8b56b15 to 6ad27dd Compare November 27, 2024 14:31
@gwenneg gwenneg merged commit 66fa4dc into RedHatInsights:master Nov 27, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikelAlejoBR MikelAlejoBR MikelAlejoBR approved these changes

@gwenneg gwenneg gwenneg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g-duval @MikelAlejoBR @gwenneg