[Backend] article-rating interlink #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enochadane
suggested changes
Aug 5, 2022
| @@ -1,3 +1,4 @@ | |||
| import { Article } from "../models/article"; | |||
| import { Rating } from "../models/rating"; | |||
|
|
|||
There was a problem hiding this comment.
We need status codes and response messages on all responses.
| @@ -72,6 +81,10 @@ export const updateRating = async (req: any, res: any) => { | |||
| try { | |||
| const rating = await Rating.findById({ _id: req.params.id }) | |||
| if (!rating) return res.status(404).send("Rating not found to be updated") | |||
There was a problem hiding this comment.
Change response message since this would be shown to users on the frontend. like.. "Rating not found!"
| @@ -2,7 +2,7 @@ import app from "./app" | |||
| import mongoose from 'mongoose'; | |||
|
|
|||
| const PORT = process.env.PORT || 8000 | |||
| const DB_URI = process.env.MONGO_URI || "mongodb://localhost:27017/test"; | |||
There was a problem hiding this comment.
No need to reveal database strings here. use env variables.
| @@ -2,7 +2,7 @@ import app from "./app" | |||
| import mongoose from 'mongoose'; | |||
|
|
|||
| const PORT = process.env.PORT || 8000 | |||
| const DB_URI = process.env.MONGO_URI || "mongodb://localhost:27017/test"; | |||
| const DB_URI = process.env.mongodb_url || "mongodb://localhost:27017/rating"; | |||
There was a problem hiding this comment.
make the variable naming better and readable.. like MONGO_URI and MONGO_URI_TEST bla bla :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
article rating interlinks