interlink comment with user #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiyadHassen
reviewed
Aug 4, 2022
| @@ -38,6 +47,12 @@ export async function addComment(req: Request,res:Response){ | |||
| } | |||
|
|
|||
| export async function deleteCommentById(req:Request,res:Response){ | |||
|
|
|||
| const user = await userModel.findById(req.params.userId); | |||
There was a problem hiding this comment.
it would be better to check if the actual user who created the comment should delete the comment,
check user._id equlaity
| @@ -47,11 +62,15 @@ export async function deleteCommentById(req:Request,res:Response){ | |||
| } | |||
|
|
|||
| export async function updateCommentById(req:Request,res:Response){ | |||
| const user = await userModel.findById(req.params.userId); | |||
There was a problem hiding this comment.
same goes here, one should update their comments.
RiyadHassen
reviewed
Aug 4, 2022
| res.status(200).json(comment); | ||
|
|
||
| // console.log(comment) |
There was a problem hiding this comment.
remove debugging statements, plus pull the master branch to resolve conflicts.
Comment on lines
37
to
38
| // console.log(comment) | ||
| // const ans = await comment.populate('author'); |
There was a problem hiding this comment.
remove debugging statments
| .populate([ | ||
| { | ||
| path: 'author ', | ||
| select: 'name -_id' |
There was a problem hiding this comment.
we need to populate picture of a user also
| @@ -2,16 +2,22 @@ import mongoose from 'mongoose'; | |||
| import {userModel} from './user-model'; | |||
| import {Article} from './article'; | |||
|
|
|||
| export interface comment_interface extends Document{ | |||
There was a problem hiding this comment.
better to rename interfaces with IComment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.