Daniel t impliment crud for rating #57
Conversation
|
|
||
|
|
||
| const app: Application = express(); | ||
| app.use(express.urlencoded({ extended: true })); | ||
| app.use(express.json()); | ||
| app.use("/" , json({})); | ||
| app.use("/api/v1", require('../src/routes/routes')); | ||
| app.use("/users/:userID/posts/:postID/rates", routes.rateRouter); | ||
| // app.use("/api/v1", require('../src/routes/routes')); |
| @@ -0,0 +1,4 @@ | |||
| const Rating = require("../models/rating"); | |||
There was a problem hiding this comment.
the file should be a typescript file. plus you can simply import the module without setting up exporting file.
| @@ -0,0 +1,24 @@ | |||
| const mongoose = require("mongoose"); | |||
|
|
|||
There was a problem hiding this comment.
add interface definition for the model that extends from mongoose.Doucment, to state the definition of the schema, state the schema definitions and model definition based on this interface
| @@ -0,0 +1,13 @@ | |||
| const express = require('express') | |||
There was a problem hiding this comment.
use import statements to adhere to es6 importing module pattern
|
|
||
| describe.only('Rating', ()=> { | ||
| beforeAll(async () => { | ||
| const mongoServer = await MongoMemoryServer.create(); |
There was a problem hiding this comment.
use setup.db to open and close in memory server
| // starts: expect.any(Number), | ||
| // user: expect.any(String) | ||
| // })) | ||
| }); |
There was a problem hiding this comment.
add more testing to the files, simulate what happens when a user rates again, test update rating and other files too.
| @@ -0,0 +1,86 @@ | |||
| const getOne = (model) => async (req, res) => { | |||
There was a problem hiding this comment.
file should be ts file, plus we don't need other folders, such as utils we can use controllers folder to handle business logics, clone master branch and work on that. plus we don't need crud for rating since its dependent on article you can add your function their.
| const ratingController = require('../controllers/rating.controller') | ||
|
|
||
|
|
||
| router.route('/').get(ratingController.getMany) |
There was a problem hiding this comment.
use articles route to handle rating, since they are dependent.
No description provided.