Nahom.crud for users #24
Conversation
| return res.status(404).end(); | ||
| } | ||
|
|
||
| res.status(200).json({ data: doc }); |
There was a problem hiding this comment.
remove password property when sending info over response
|
|
||
| res.status(200).json({ data: doc }); | ||
| } catch (e) { | ||
| console.error(e); |
There was a problem hiding this comment.
remove debugging statements
| const docs = await userModel.find().lean().exec(); | ||
| res.status(200).json({ data: docs }); | ||
| } catch (e) { | ||
| console.error(e); |
There was a problem hiding this comment.
remove debugging statement
| export const getAllUsers = async (req: Request, res: Response) => { | ||
| try { | ||
| const docs = await userModel.find().lean().exec(); | ||
| res.status(200).json({ data: docs }); |
There was a problem hiding this comment.
here also you are sending password as a response
| }; | ||
| export const createUser = async (req: Request, res: Response) => { | ||
| try { | ||
| const doc = await userModel.create({ ...req.body }); |
There was a problem hiding this comment.
passing the whole req.body is not recommended so better to extract each property from req.body and pass it to create function
| const doc = await userModel.create({ ...req.body }); | ||
| return res.status(200).json({ data: doc }); | ||
| } catch (e) { | ||
| console.error(e); |
| return res.status(200).json({ data: removed }); | ||
| } catch (e) { | ||
| console.error(e); | ||
| res.status(404).end(); |
There was a problem hiding this comment.
better to send 500(internal server error from catch statement since client error has been handle in the try block
| }) | ||
| ) | ||
| expect(statusCode).toBe(200); | ||
| }) |
There was a problem hiding this comment.
add more tests to each request and each scenario (failure and success scenarios)
nahom.CRUD-for-Users