Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping - Upgrade dependencies #12741

Merged
merged 6 commits into from
Aug 18, 2023
Merged

Housekeeping - Upgrade dependencies #12741

merged 6 commits into from
Aug 18, 2023

Conversation

Tawakalt
Copy link
Contributor

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Tawakalt Tawakalt marked this pull request as ready for review August 16, 2023 17:07
@Tawakalt Tawakalt requested a review from Urkem August 16, 2023 17:07
@vcidst
Copy link
Contributor

vcidst commented Aug 17, 2023

Is this a duplicate of #12740 it seems like engine-atom both do the same upgrades sometimes 🤔

@Tawakalt
Copy link
Contributor Author

No it's not.
12740 only upgrades a single dependency. We can close that once this gets merged.

Urkem
Urkem reviewed Aug 18, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@Tawakalt Tawakalt requested a review from Urkem August 18, 2023 09:56
@Tawakalt Tawakalt enabled auto-merge August 18, 2023 09:59
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@Tawakalt Tawakalt merged commit c4a2d69 into main Aug 18, 2023
@Tawakalt Tawakalt deleted the ATO-1383-handle-dependency-upgrades branch August 18, 2023 11:07
@Tawakalt Tawakalt mentioned this pull request Aug 18, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urkem Urkem Urkem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tawakalt @vcidst @Urkem