Log error if GetVRGFromManagedCluster failed #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We returned false, swallowing the error silently.
The drpc remained in this state:
- lastTransitionTime: "2024-12-10T12:45:26Z"
message: unable to start failover, spec.FailoverCluster (dr2) is not a valid
Secondary target
With no clue why dr2 is not a valid Secondary cluster. The new log may
explain the reason.
Signed-off-by: Nir Soffer <[email protected]>
BenamarMk
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We returned false, swallowing the error silently.
The drpc remained in this state:
With no clue why dr2 is not a valid Secondary cluster. The new log may explain the reason.