e2e: Improve discovered apps infrastructure #1706
Conversation
|
@nirs I agree with the overall idea. There is one typo that needs to be fixed. I am still debating if we should have a function in the interface that returns bool for discovered or just have a function called deployerType and returns a string. However, we can merge this and make changes later if we think the other way is better. |
Since this is not an API, we can use a bool now an change this later in the unlikely case that there will be another strange deployer which is not discovered. |
|
@raghavendra-talur should be ready when the e2e job completes. |
This clarifies code dispatching actions for discovered apps, eliminating cryptic type assertions. It also eliminates the dependency on the deployers package from dractions/actions.go. Signed-off-by: Nir Soffer <[email protected]>
- Rename DiscoveredApps to DiscoveredApp for consistency with other deployers names. - Rename deployers/discoveredapps.go to deployers/discoveredapp.go to match the new type name. - Rename dractions/actionsdiscoveredapps.go to dractions/discovered.go - this name was too long, hard to read, and breaks log formatting. - Rename util.RamenOpsNS to util.RamenOpsNamespace for consistency with other constants. Signed-off-by: Nir Soffer <[email protected]>
Example log: