Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More typos fixes #1690

Merged
merged 4 commits into from
Dec 4, 2024
Merged

More typos fixes #1690

merged 4 commits into from
Dec 4, 2024

Conversation

nirs
Copy link
Member

@nirs nirs commented Dec 2, 2024

Most of the fixes are in comments, error messages, constants, and variable names.

One fix in progression name and text, which may affects users that hard coded the old progression value.

@nirs nirs marked this pull request as draft December 2, 2024 16:53
nirs added 4 commits December 2, 2024 18:57
Fix typos in comments, error messages and error name.

Signed-off-by: Nir Soffer <[email protected]>
Fix typos in comments included in generated crd:
ramendr.openshift.io_drplacementcontrols.yaml

Signed-off-by: Nir Soffer <[email protected]>
Rename ProgressionCheckingFailoverPrequisites to ProgressionCheckingFailoverPrerequisites
and update the progress message. This may break users hard-coding the
progression text.

Signed-off-by: Nir Soffer <[email protected]>
The name `pn` is flagged as typo. Lets use a more clear name that makes
the code more readable and keep the speller happy.

Signed-off-by: Nir Soffer <[email protected]>
@nirs nirs marked this pull request as ready for review December 2, 2024 17:04
@ShyamsundarR ShyamsundarR merged commit 98b40db into RamenDR:main Dec 4, 2024
23 checks passed
@nirs nirs deleted the typos branch December 4, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants