Bump go version to 1.22, rook version to 1.15 and csi-addon to 0.9.0

[ELENAGER]

No description provided.

[nirs]

Squashing this commit to to the first one would be best.

[nirs]

But - there is a better way - instead of getting go version from this variable, which needs future maintenance, we can get it the go version from the go.mod file[1]

In each usage of setup-go:

  - name: Setup go
    uses: actions/setup-go@v5
    with:
      go-version-file: go.mod

[1] https://github.com/actions/setup-go?tab=readme-ov-file#getting-go-version-from-the-gomod-file

[ELENAGER]

Squashed. The proposed changed can be made in another PR, it's not straigh-forward, GO_VERSION constant is in use afterwards.

[nirs]

1.22 works:

--- a/go.mod
+++ b/go.mod
@@ -1,6 +1,6 @@
 module github.com/ramendr/ramen
 
-go 1.21
+go 1.22

Running go mod tidy and make does not change to 1.22.0. Did yo add it manually or some tool changed it?

[ELENAGER]

Changing to 1.22 and running go mod tidy gives me the following error:
go: downloading go1.22 (linux/amd64)
go: download go1.22 for linux/amd64: toolchain not available

Using 1.22.0 is fixing it.

[nirs]

Maybe because you don't have go 1.22 installed on you machine?

You can install multiple go versions:
https://go.dev/doc/manage-install

If we depend automatic download of go version for building, we can require the latest version: 1.22.6.

[raghavendra-talur]

I think we need to do this change that Nir suggests.

Edit: I only refer to the part about keeping it go 1.22 and not go 1.22.0. We can do the automatic download of go version in the CI later.

[nirs]

Are you sure this is the right version? we are using crds and images from 0.9.0, but api from 0.8.1-...? This looks wrong. How did you create this requirement?

I guess you did:

go get github.com/csi-addons/kubernetes-csi-addons@89d4c5b45a3258587d2e8054183470093385308c

When doing such unexpected changes (and specially in a big commit like this), we need to explain whats going on in the commit message. Something like:

We update csi-addon to 0.9.0, but we cannot build with this version because
... we have to build with commit (link the commit). The requirement was
created like this ...

Also a line about the need to update rook an csi-addons in the same time is helpful. Explain why we cannot update each component without the other.

[ELENAGER]

I have to use specific commit from CSI because of the constants, that they forgot to expose in 0.9.0 and merged later. I don't like this situation also, if you can suggest a better solution - let's discuss it.

[nirs]

I think this is fine for a temporary change until we get a new 0.9.1 wit this fix.

@Madhu-1 do you plan to release 0.9.1 soon?

[Madhu-1]

not at the moment (at least not in 3 weeks unless we have bugs that need a release)

[raghavendra-talur]

@ELENAGER You can get a higher commit than 0.9.0. The line should look like v0.9.1-...

[ShyamsundarR]

@raghavendra-talur can you take a look at the go.mod and build (dockerfile) changes and we can merge if things look fine.

@ELENAGER if there is a CSI addons issue, we can link it to one of our issues to move to the right versions when it is released.

[ShyamsundarR]

We should move this to latest 1.22.z (which seems to be 6) (here and other places as well)

[ELENAGER]

@ShyamsundarR Done.

[ELENAGER]

@ShyamsundarR this is the CSI issue csi-addons/kubernetes-csi-addons#649

[nirs]

I think it is ok to merge assuming that we get 0.9.1 release in few weeks. Testing with latest rook early is important.