Implement DRClusterConfig reconciler to create required ClusterClaims #1485

ShyamsundarR · 2024-07-10T12:00:41Z

Part of #1403

This implements creation of ClusterClaims for the various classes detected on the ManagedCluster that is also marked via a DRClusterConfig as a DR peer.

Future considerations:

Add a basic status (say status.Message and observedGeneration) to DRClusterConfig reflecting success or failure of reconciliation
Add required CEL immutability rules to DRClusterConfig, as certain fields should not be changed once created (e.g clusterID)
DRClusterConfig can check s3 accessibility and report issues regarding the same, closing the gap for S3 validation on the ManagedCluster
Add any required clusterID validation

ELENAGER · 2024-07-15T11:12:24Z

internal/controller/drclusters.go

+		return err
+	}
+
+	if _, err := mwu.FindManifestWork(mwu.BuildManifestWorkName(util.MWTypeDRCConfig), drcluster.GetName()); err == nil {


@ShyamsundarR it's the only place we are checking manifest after deletion. If there is no error in line 248, the manifest will be deleted, so why we need an additional check?

Good question, I want to ensure that the DRClusterConfig resource at the managed cluster is deleted before we proceed to delete the MW for the ramen components at the managed cluster. If we reach that before the resource is actually deleted, then the DRClusterConfig reconciler may not be existing to finalize the resource locally.

Hence we delete and wait till it is actually deleted, then we proceed with deletion of the ramen operators on the managed cluster.

ELENAGER · 2024-07-16T07:21:10Z

internal/controller/util/mw_util.go

+) error {
+	rawObject, err := GetRawExtension(mw.Spec.Workload.Manifests, gvk)
+	if err != nil {
+		return fmt.Errorf("failed fetching MaintenanceMode from manifest %w", err)


failed fetching resource from manifest? Not MaintenanceMode

ELENAGER · 2024-07-16T07:21:45Z

internal/controller/util/mw_util.go

+
+	err = json.Unmarshal(rawObject.Raw, object)
+	if err != nil {
+		return fmt.Errorf("failed unmarshaling MaintenanceMode from manifest %w", err)


Same as previous

ELENAGER · 2024-07-16T11:27:00Z

internal/controller/drcluster_controller.go

 	if err := u.statusUpdate(); err != nil {
 		u.log.Info("failed to update status", "failure", err)
 	}

-	return ctrl.Result{Requeue: requeue || u.requeue}, reconcileError
+	return ctrl.Result{Requeue: requeue || u.requeue}, nil


If there is an error during fencing - we will not return error?

If there is an error in fencing we will note that in the status and log it, and we set requeue to true (for future reconciles). Returning an error is not required at this point.

ELENAGER · 2024-07-16T11:57:29Z

internal/controller/drcluster_controller.go

+	// another DRPolicy
+	added := map[string]bool{}
+
+	for idx := range drpolicies.Items {


Is it possible, that policy is marked for deletion? Do we need to handle it anyway?

Interestingly there is a test case for this that passes, though based on the comment I think it is possible that we may retain a stale schedule till a future DRCluster reconcile (due to any reason) is initiated. Will fix this by skipping deleted DRPolicies in the loop.

The parent PR that this is a part of is merged, hence will address it as a separate PR.

BenamarMk

LGTM

Also, cleanup some scaffolding comments. Signed-off-by: Shyamsundar Ranganathan <[email protected]>

- Add finalizer to resource being reconciled - Remove on delete - Update reconciler to rate limit max exponential backoff to 5 minutes Signed-off-by: Shyamsundar Ranganathan <[email protected]>

Signed-off-by: Shyamsundar Ranganathan <[email protected]>

Building the scaffold for the overall functionality. Signed-off-by: Shyamsundar Ranganathan <[email protected]>

Signed-off-by: Shyamsundar Ranganathan <[email protected]>

For classes listed, those that do not need a ClusterClaim any longer are deleted. Added a StorageClass watcher as well to the reconcile on changes to StorageClasses. Signed-off-by: Shyamsundar Ranganathan <[email protected]>

Signed-off-by: Shyamsundar Ranganathan <[email protected]>

…RamenDR#1485) * Add logger to DRClusterConfig reconciler Also, cleanup some scaffolding comments. Signed-off-by: Shyamsundar Ranganathan <[email protected]> * Add initial reconcile for DRClusterConfig - Add finalizer to resource being reconciled - Remove on delete - Update reconciler to rate limit max exponential backoff to 5 minutes Signed-off-by: Shyamsundar Ranganathan <[email protected]> * Add roles for various storage classes and cluster claims Signed-off-by: Shyamsundar Ranganathan <[email protected]> * Add StorageClass listing and dummy functions for claim creation Building the scaffold for the overall functionality. Signed-off-by: Shyamsundar Ranganathan <[email protected]> * Add ClusterClaims for detected StorageClasses Signed-off-by: Shyamsundar Ranganathan <[email protected]> * Implement pruning of ClusterClaims For classes listed, those that do not need a ClusterClaim any longer are deleted. Added a StorageClass watcher as well to the reconcile on changes to StorageClasses. Signed-off-by: Shyamsundar Ranganathan <[email protected]> * Implement CLassClaims for VRClass and VSClass Signed-off-by: Shyamsundar Ranganathan <[email protected]> --------- Signed-off-by: Shyamsundar Ranganathan <[email protected]>

ShyamsundarR marked this pull request as draft July 10, 2024 12:00

ShyamsundarR force-pushed the claimcreation branch 3 times, most recently from cd24518 to 8b258ad Compare July 12, 2024 14:18

ShyamsundarR marked this pull request as ready for review July 14, 2024 15:37

ShyamsundarR requested review from rakeshgm, ELENAGER and raghavendra-talur July 14, 2024 15:40

ELENAGER reviewed Jul 15, 2024

View reviewed changes

ELENAGER reviewed Jul 16, 2024

View reviewed changes

ShyamsundarR force-pushed the claimcreation branch 2 times, most recently from e822464 to a1c09b4 Compare July 19, 2024 15:50

BenamarMk approved these changes Aug 8, 2024

View reviewed changes

ShyamsundarR force-pushed the claimcreation branch 2 times, most recently from 62b1124 to 8f10323 Compare August 20, 2024 14:57

ShyamsundarR added 7 commits September 11, 2024 11:05

Add logger to DRClusterConfig reconciler

bf9b7f8

Also, cleanup some scaffolding comments. Signed-off-by: Shyamsundar Ranganathan <[email protected]>

Add initial reconcile for DRClusterConfig

4cf2d7d

- Add finalizer to resource being reconciled - Remove on delete - Update reconciler to rate limit max exponential backoff to 5 minutes Signed-off-by: Shyamsundar Ranganathan <[email protected]>

Add roles for various storage classes and cluster claims

262bef6

Signed-off-by: Shyamsundar Ranganathan <[email protected]>

Add StorageClass listing and dummy functions for claim creation

ceca833

Building the scaffold for the overall functionality. Signed-off-by: Shyamsundar Ranganathan <[email protected]>

Add ClusterClaims for detected StorageClasses

b7fa70f

Signed-off-by: Shyamsundar Ranganathan <[email protected]>

Implement pruning of ClusterClaims

16d66a9

For classes listed, those that do not need a ClusterClaim any longer are deleted. Added a StorageClass watcher as well to the reconcile on changes to StorageClasses. Signed-off-by: Shyamsundar Ranganathan <[email protected]>

Implement CLassClaims for VRClass and VSClass

e3fe7f6

Signed-off-by: Shyamsundar Ranganathan <[email protected]>

ShyamsundarR force-pushed the claimcreation branch from 8f10323 to e3fe7f6 Compare September 12, 2024 12:08

BenamarMk merged commit 91e5a5b into RamenDR:main Sep 18, 2024
19 of 20 checks passed

ShyamsundarR deleted the claimcreation branch September 18, 2024 16:37

ShyamsundarR mentioned this pull request Sep 18, 2024

Ensure deleted DRPolicies do not add schedules to DRClusterConfig #1565

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement DRClusterConfig reconciler to create required ClusterClaims #1485

Implement DRClusterConfig reconciler to create required ClusterClaims #1485

ShyamsundarR commented Jul 10, 2024 •

edited

Loading

ELENAGER Jul 15, 2024

ShyamsundarR Jul 15, 2024

ELENAGER Jul 16, 2024

ShyamsundarR Jul 16, 2024

ELENAGER Jul 16, 2024

ShyamsundarR Jul 16, 2024

ELENAGER Jul 16, 2024

ShyamsundarR Jul 16, 2024

ELENAGER Jul 16, 2024

ShyamsundarR Jul 19, 2024

BenamarMk left a comment

Implement DRClusterConfig reconciler to create required ClusterClaims #1485

Implement DRClusterConfig reconciler to create required ClusterClaims #1485

Conversation

ShyamsundarR commented Jul 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BenamarMk left a comment

Choose a reason for hiding this comment

ShyamsundarR commented Jul 10, 2024 •

edited

Loading