Retain serviceIdentifier in MapToolServer objects #5143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 19, 2025
fishface60
force-pushed
the
refactor-MapToolServer
branch
from
59cc4b7 to
d7d6ca4
Compare
cwisniew
approved these changes
Jan 19, 2025
|
Merged and will be included in 1.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
fixes #5142
depended on by #5126
depended on by #5076
Description of the Change
This retains the service ID that's announced by the ServiceIdentifier in the MapToolServer class, so that it can be returned elsewhere.
Possible Drawbacks
serviceIdentifieris a bit opaque compared to LAN ID, but service is the nomenclaiture of the ServiceAnnouncer andIdentifierhas more consistent capitalisation rules thanID, as older code expects acronyms to remain capitalised and would beserviceID, but the rust style is also popular in the codebase and would beserviceId.Documentation Notes
Not applicable
Release Notes
Not applicable
This change is