Bump upnplib to latest version #5131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 5, 2025
fishface60
force-pushed
the
update-upnplib
branch
from
5b8bbc9 to
690b196
Compare
fishface60
force-pushed
the
update-upnplib
branch
from
690b196 to
e4058d5
Compare
cwisniew
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
closes #5123
Description of the Change
This updates the gradle config to use an updated version of the MapTool fork of UPnPlib.
This is an alternative to #5124
Possible Drawbacks
Some routers support both InternetGatewayDevice:1 and InternetGatewayDevice:2 interfaces and it's implementation defined what to do. For the Unifi it accepts duplicate port mapping requests. MapTool will attempt to unmap twice but it gracefully handles failures.
Another router which rejects duplicate mappings shouldn't cause problems since UPnPUtil considers it a success if at least one mapping is successful, but this code path is untested and could cause confusing spurious error messages.
Release Notes
This change is