Modify ButtonGroup drag to check for no change #4888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…group. Before checking for permissions, if there is no change in button group it returns false.
cwisniew
approved these changes
Sep 12, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4883
Description of the Change
When a macro button is dragged, logic now checks for change in button group first and exits if there is no change.
This prevents accidental small drags and drags that have no effect progressing to permission checks and further processing.
Permission error message only presents when there is a change in the button group value.
Possible Drawbacks
none
Documentation Notes
Stopped permission error message for dragging macro buttons where there is no change.
Release Notes
Stopped permission error message for dragging macro buttons where there is no change.
This change is