Constrain zoom levels #4809
Merged
Constrain zoom levels #4809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scale and zoom level can never vary independently. The copy constructor and readResolve() now enforce the zoom level being calculated from the scale. Also includes a bunch of clean up for unused fields.
Minimum is still -175, there's just no reason they have to be the same.
We were passing 4 (`RIGHT`) as the number of column rather than the alignment. This has been fixed, and the column count bumped up to 9. With the extra space, we now format the numbers to always display 5 digits.
cwisniew
approved these changes
May 30, 2024
|
Approved although I wonder about your definition of "reasonable" for the range :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #2264
Description of the Change
The zoom level has been clamped to a more reasonable range.
These numbers aren't very meaningful aside from avoiding the extremes while still giving lots of freedom. There's a bit of room on each side yet if we want to push it.
The
AdjustGridPanelandAdvancedAdjustGridPanelwere removed as they were unused and put extra requirements onScale.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
This change is