Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist new public keys in the player database when using Easy Connect #4780

Merged

Conversation

kwvanderlinde
Copy link
Collaborator

@kwvanderlinde kwvanderlinde commented May 15, 2024

Identify the Bug or Feature request

Fixes #4779

Description of the Change

Commits the player database whenever new keys are added as part of Easy Connect. Previously we only committed if the player was already known, but now we do it regardless.

Possible Drawbacks

Should be none.

Documentation Notes

N/A

Release Notes

  • Fixed a bug where Easy Connect clients were forgotten after server restart.

This change is Reviewable

Do it whether the player was previously known or not.
@kwvanderlinde kwvanderlinde force-pushed the bugfix/4779-easy-connect-commit branch from a4863ba to 098ad82 Compare May 15, 2024 06:35
@kwvanderlinde kwvanderlinde self-assigned this May 15, 2024
@Azhrei Azhrei added this pull request to the merge queue May 17, 2024
Merged via the queue into RPTools:develop with commit a56f70c May 17, 2024
4 checks passed
@kwvanderlinde kwvanderlinde deleted the bugfix/4779-easy-connect-commit branch May 17, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[Bug]: Easy Connect approvals are not remembers across server starts
3 participants