Replace configSentryRelease task with processResources configuration #4401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids dirtying the `src/` directory with build artifacts, thus introducing unexpected dependencies between tasks. The `:run` task naturally no longer depends on `:spotlessCheck` in any way. The `src/main/resources/sentry.properties` file is no longer ignored by git as it should not be generated by the build anymore. If the file is present in a dev tree, it should be deleted.
thelsing
approved these changes
Nov 15, 2023
kwvanderlinde
deleted the
refactor/4399-avoid-writing-sentry-config-to-src-dir
branch
This was referenced Nov 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Addresses #4399
Description of the Change
This avoids dirtying the
src/directory with build artifacts, thus introducing unexpected dependencies between tasks. The:runtask naturally no longer depends on:spotlessCheckin any way.Possible Drawbacks
Devs will need to do a one-time deletion of the
src/main/resources/sentry.propertiesbuild artifact as it is not being tracked by git.Documentation Notes
N/A
Release Notes
N/A
This change is