Fix Grid Size labelling - Again #4350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added GridRenderStyle to ZoneRenderer
changed default grid colour to translucent yellow draw half hexes not full hexes draw two colours
Introduced some enums and classes to support interesting grids Signed-off-by: bubblobill <[email protected]>
Moved grid related things to package net.rptools.maptool.model.grid Introduced some enums and classes to support interesting grids Signed-off-by: bubblobill <[email protected]>
optimising created assorted i18n keys for Grids Signed-off-by: bubblobill <[email protected]>
Signed-off-by: bubblobill <[email protected]>
|
This PRs does much more than specified according to the file diff:
As the changes are not related to #4350 this was probably not intended? |
Signed-off-by: bubblobill <[email protected]>
Signed-off-by: bubblobill <[email protected]>
|
Oh FFS. I hate you GItHub and your IntelliJ friend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4349
Description of the Change
Had to delete unapproved Hide Token Stack controls on preferences dialog in order to get this to run.
Preferences, Map, and Grid Adjust dialogues now consistently refer to Grid Size with a tooltip detailing it as cells size in pixels
Possible Drawbacks
none
Documentation Notes
Fix inconsistency in UI reference to grid size
Release Notes
Fix inconsistency in UI reference to grid size
This change is