Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change getAllPropertyNames to return empty string/JSON array if type invalid #3548

Merged
merged 6 commits into from
Aug 18, 2022

Conversation

Phergus
Copy link
Contributor

@Phergus Phergus commented Aug 15, 2022

Identify the Bug or Feature request

For #3387

Description of the Change

Instead of throwing a parser exception, calls to getAllPropertyNames() will return an empty string or an empty JSON array if the property type is not found.

Possible Drawbacks

None expected.

Documentation Notes

If property type is not found on current token an empty string or empty JSON array will be returned.

Release Notes

getAllPropertyNames() now returns empty string/JSON array if property type is invalid


This change is Reviewable

Return either an empty string or an empty array if Property Type isn't found.
@Phergus Phergus requested a review from cwisniew August 15, 2022 20:43
@Phergus Phergus merged commit f2b91e4 into RPTools:develop Aug 18, 2022
@Phergus Phergus deleted the issue3387propertyNames branch August 18, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants