-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPP Exclusive-Or on HOST and HIP #464
Open
r-abishek
wants to merge
63
commits into
ROCm:develop
Choose a base branch
from
r-abishek:ar/opt_bitwise_xor
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,864
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
r-abishek
commented
Oct 30, 2024
•
edited
Loading
edited
- Updates version to RPP 1.9.9
- Add HOST and HIP implementations for Exclusive-Or operation
- Add support for NCHW/NHWC, toggle variants with U8/F16/F32/I8 bit depth
- Add relevant unit/perf/qa tests
rrawther
requested changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@r-abishek: Please check with @AryanSalmanpour for HIP kernel review
spolifroni-amd
approved these changes
Dec 2, 2024
Exclusive OR - Merge conflicts resolved
@r-abishek - conflicts |
Bitwise XOR - Merge conflicts resolved again
Bitwise XOR - Merge Conflicts Update
rrawther
approved these changes
Jan 7, 2025
@r-abishek - please fix merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.