Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPP Rain augmentation on HOST and HIP #463

Merged
merged 50 commits into from
Jan 15, 2025
Merged

RPP Rain augmentation on HOST and HIP #463

merged 50 commits into from
Jan 15, 2025
+1,816 −10

Conversation

r-abishek
Copy link
Member

@r-abishek r-abishek commented Oct 23, 2024 •
edited
Loading

  • Adds to version to RPP 1.9.10
  • Adds a dash-cam rain augmentation on HOST and HIP
  • Adds support for U8/F16/F32/I8 bit depths with NCHW/NHWC tensor support
  • Adds relevant unit/perf tests

HazarathKumarM and others added 26 commits August 19, 2024 04:16
@HazarathKumarM
Add Intial u8 implementation for Rain
aa1af83
@HazarathKumarM
Add I8 implementation and Changes based on the Review comments
085e243
@HazarathKumarM
Initial HIP implementation
2558cfa 
Add F32 and F16 Tensor Implementation
@HazarathKumarM
Merge remote-tracking branch 'TOT/develop' into hk/rain
e8ae15b
@HazarathKumarM
Add test case for Rain in HIP test suite
4c89f7a 
code cleanup
@HazarathKumarM
minor code cleanup
395bdc6
@HazarathKumarM
Modified func names and removed unnecessary code
bffe622
@HazarathKumarM
Resolve Review comments
bfc3592
@HazarathKumarM
replaced pinned memory with HIP memory for Rain Layer computation
fba3773
@HazarathKumarM
Modified RGB Rain Mask to planar Rain Mask in HIP
32799ed
@HazarathKumarM
Address review comments
ed1d83c
@HazarathKumarM
Add Rain compute function
8a8ab59
@HazarathKumarM
Add version changes and Resolve review comments
000ab57
@HazarathKumarM
fix build warnings
6aac89c
@HazarathKumarM
Fix the outputs of f16 toggle variants
21aaa2c
@HazarathKumarM
Revert Rain width changes
fdd622d
@HazarathKumarM
Merge remote-tracking branch 'abishek/develop' into hk/rain
b482e96
@HazarathKumarM
Fix pln3 outputs for u8 and i8 bitdepths
655d841
@HazarathKumarM
Resolve review comments
9003435
@HazarathKumarM
Modified load and store routines for planar cases
3a23fa4
@HazarathKumarM
Resolve review comments
d940131
@HazarathKumarM
Merge remote-tracking branch 'develop' into hk/rain
b3030c9
@HazarathKumarM
Modify docs image
3ff4958
@HazarathKumarM
Merge remote-tracking branch 'ar/opt_rain' into hk/rain
f6e845c
@r-abishek
Merge pull request #319 from HazarathKumarM/hk/rain
d479c5c 
RPP Rain Tensor
@r-abishek
Fix versioning
19a1557
@r-abishek r-abishek requested a review from a team as a code owner October 23, 2024 05:45
@kiritigowda kiritigowda requested a review from rrawther October 29, 2024 20:22
@kiritigowda kiritigowda self-assigned this Oct 29, 2024
@kiritigowda kiritigowda added the enhancement New feature or request label Oct 29, 2024
spolifroni-amd
spolifroni-amd requested changes Dec 2, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@kiritigowda
Copy link
Collaborator

@r-abishek - needs conflicts resolved

@kiritigowda kiritigowda marked this pull request as draft December 23, 2024 20:28
@r-abishek
Merge pull request #374 from HazarathKumarM/hk/rain_merge
e32fbe0 
RPP Rain - Resolved Merge Conflicts
@kiritigowda kiritigowda marked this pull request as ready for review December 30, 2024 22:46
rrawther
rrawther reviewed Jan 3, 2025
View reviewed changes
utilities/test_suite/HIP/Tensor_hip.cpp Outdated
@@ -432,6 +432,10 @@ int main(int argc, char **argv)
if(testCase == 28)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use ENUM for test case instead of hardcoded values for better code readability

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed with #499

spolifroni-amd
spolifroni-amd approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@spolifroni-amd spolifroni-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The points in the changed section need to be changed so they have more info (what was it before; what is it now; what, if anything, does the user need to do)

But I don't want to hold up the review process so I'll OK this as is and we can change it later.

@kiritigowda
Copy link
Collaborator

@r-abishek can you look at the conflicts

@r-abishek
Copy link
Member Author

@kiritigowda Could we merge this PR?
Conflicts resolved, Azure passing.

@kiritigowda kiritigowda merged commit d2fdd62 into ROCm:develop Jan 15, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spolifroni-amd spolifroni-amd spolifroni-amd approved these changes

@rrawther rrawther rrawther approved these changes

@AryanSalmanpour AryanSalmanpour Awaiting requested review from AryanSalmanpour

Assignees

@kiritigowda kiritigowda

Labels
ci:precheckin enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@r-abishek @kiritigowda @rrawther @spolifroni-amd @HazarathKumarM @Srihari-mcw