Bottleneck Characterization #379
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…376) * Fix crash in multi-GPU scenario Exclude -o option when invoking rocprof so that each rocprof process writes to a different .csv file. Concatenate into a single .csv file when finished. Signed-off-by: benrichard-amd <[email protected]> * Only combine csv files when using rocprofv2 rocprofv1 does not have separate csv files Signed-off-by: benrichard-amd <[email protected]> * Fix indices in combined CSV file Use ignore_index flag to ensure there are no duplicate indices. Signed-off-by: benrichard-amd <[email protected]> * Fix Dispatch_ID column and remove unnamed column -Pandas was inserting an unnamed column (index column) -Overwrite the Dispatch_ID column so that every row is unique, starting at 0 -Remove fixup_rocprofv2_dispatch_ids as no longer needed Signed-off-by: benrichard-amd <[email protected]> * Fix code formatting Signed-off-by: benrichard-amd <[email protected]> * Fix code formatting (for real this time) Signed-off-by: benrichard-amd <[email protected]> --------- Signed-off-by: benrichard-amd <[email protected]>
* Workload Characterization Scripts Adding three new workload characterization python scripts. Signed-off-by: dwchang79 <[email protected]> * Create Workload_Characterization_Manual.pdf Documentation on how to use the Workload Characterization Tools Signed-off-by: dwchang79 <[email protected]> * Update Workload_Characterization_Manual.pdf Minor additions to the documentation --------- Signed-off-by: dwchang79 <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
…odes Signed-off-by: coleramos425 <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
coleramos425
force-pushed
the
amd-staging
branch
from
6265391 to
0d15023
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds off of #242 which added "Bottleneck Characterization" to Omniperf, consisting of
I have modified the code so that the characterization and plotting modules match Omniperf's class based structure. See original PR for the feature's methodology and docs
Usage
To use the "Bottleneck Characterization" feature, just ensure omnitrace (specifically
omnitrace-instrument) is available on your PATH. Omniperf will automatically run instrumentation as part of its profiling pipeline (disable using--no-trace). You can find your .proto output file in the standard Omniperf output directory.Use analyze mode to generate the output plots (.pdf versions will also be saved by default). If for whatever reason you'd like to explicitly specify a .proto trace file you can do so in analysis using the
--traceflag.omniperf analyze -p workloads/dummy/MI200 --trace dummy_app.proto --guiYou'll notice the standalone GUI view now highlights these two plots in the previously empty top section of the webpage
Todo
--bottleneck-traceoption to be used without--gui