Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run less tests for CI #199

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Run less tests for CI #199

merged 3 commits into from
Jan 14, 2025

Conversation

charleshofer
Copy link
Collaborator

We don't need to run the full test suite for CI. Only run the core tests for now.

Story: https://github.com/ROCm/frameworks-internal/issues/9948

@charleshofer
Copy link
Collaborator Author

I'm completely open to adding more tests here, but right now our CI run is taking over an hour. At minimum, I think we should cut out the tests for experimental tests for things like Pallas, but I'm open to doing whatever you guys think is necessary for CI here.

@charleshofer
Copy link
Collaborator Author

charleshofer commented Jan 9, 2025

Wow, not running every test under the sun cuts us down to about a 15 min CI time:
image

Still not great, but workable, I think.

Copy link

@Ruturaj4 Ruturaj4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charleshofer charleshofer merged commit ea6903b into rocm-main Jan 14, 2025
8 checks passed
@charleshofer charleshofer deleted the run-less-tests branch January 14, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants