Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CK_TILE] Add GetName for GEMM kernels #1791

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

aledudek
Copy link
Contributor

@aledudek aledudek commented Jan 3, 2025

Proposed changes

Add GetName for GEMM kernels to easily print its name and a few other details.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

Small change. I am also open to print other kernel parameters.

Copy link
Collaborator

@aosewski aosewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be beneficial to make it much more comprehensive. Lets add also the size of warp tiles next to block tile. Additionally I'd add similar functions to Pipelines and block gemms, so that later on during benchmarking we could easily get report with what instance we're working on.

include/ck_tile/ops/gemm/kernel/gemm_kernel.hpp Outdated Show resolved Hide resolved
include/ck_tile/ops/gemm/kernel/grouped_gemm_kernel.hpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants