SWDEV-341212 - HIP header changes for supporting SPIR-V #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexVlx
requested review from
chrispaquot,
gandryey,
saleelk,
mangupta and
rakesroy
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes almost all uses of the deprecated
__AMDGCN_WAVEFRONT_SIZEmacro, which is unavailable when targeting SPIR-V, and adds a SPIR-V compatible formulation ofwarpSize(which should end up as the sole definition ofwarpSizeonce we remove support for treating it as a compile time constant). It is incomplete in that the cooperative_groups implementation will need additional surgery.