Modernize CMake #629
Open
Modernize CMake #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Galantsev, Dmitrii <[email protected]>
find_package has a REQUIRED parameter which will make CMake fail if the package is not found. RVS depends on YAML - add it as as dependency. Signed-off-by: Galantsev, Dmitrii <[email protected]>
dmitrii-galantsev
changed the title
Signed-off-by: Galantsev, Dmitrii <[email protected]>
Previously it would fail with 'cannot write to /rvs' because CPACK_PACKAGING_INSTALL_PREFIX wasn't expanded. Signed-off-by: Galantsev, Dmitrii <[email protected]>
Comment on lines
+146
to
+147
| set(CPACK_DEBIAN_PACKAGE_DEPENDS "rocblas, libyaml-cpp-dev") | ||
| set(CPACK_RPM_PACKAGE_REQUIRES "rocblas, yaml-cpp-devel") |
There was a problem hiding this comment.
These changes are largely untested because I don't have rocblas in all of my docker images.
From a quick check - yaml-cpp-devel is present on rhel 8.x, 9.x, and opensuse tumbleweed. libyaml-cpp-dev is present on ubuntu 22.04.
|
bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CMAKE_INSTALL_PREFIX and CPACK_PACKAGING_INSTALL_PREFIX have "/opt/rocm" hardcoded. This pull request resolves the issue by deriving from a common variable: ROCM_PATH.
This change also adds 2 options which are helpful for debugging and modern editors. These don't have an effect on compilation.